Review Request: Make Strigi optional on OS X

[Vishesh Handa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108315/#review25141
-----------------------------------------------------------


AFAIK, Strigi is only used if KFileMetaInfo in kdelibs. Removing it will break the following - http://lxr.kde.org/ident?i=KFileMetaInfo

The most notable of these is wallpaper handling in Plasma. I'm not sure if it will break - but it won't display the resolution of the images when choosing a wallpaper.

You could also possibly do the same in kde-runtime. There seems to be a trash analyzer for strigi, but that hasn't been installed since 2007 -

commit f3578b6c8c27ff1808cb464e5a95fc803e6c84b0
Author: Laurent Montel <montel at kde.org>
Date:   Fri Apr 20 10:06:23 2007 +0000

    Don't install it for the moment
    need to fix it
    
    svn path=/trunk/KDE/kdebase/runtime/; revision=656108

I wonder why it is still being compiled. If it is not required, then it can be thrown away and strigi can be removed as a dependency from kde-runtime completely (Linux, Mac and Windows)


- Vishesh Handa


On Jan. 10, 2013, 3:49 a.m., Yue Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108315/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2013, 3:49 a.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> Some kde apps can work without strigi on OS X, this patch is for reduce dependencies when packaging those apps, but i don't know whether it can be optional for official kdelibs on OS X. So I put it here, please give some comments.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 5df26e5 
>   kde3support/CMakeLists.txt 2e91b73 
>   kdewidgets/CMakeLists.txt 5153601 
>   kfile/CMakeLists.txt ceae140 
>   khtml/CMakeLists.txt 99034cc 
>   kio/kio/kfilemetainfo.h 6920ffe 
>   kioslave/metainfo/CMakeLists.txt cbf2d86 
>   kparts/CMakeLists.txt 2eab2e8 
> 
> Diff: http://git.reviewboard.kde.org/r/108315/diff/
> 
> 
> Testing
> -------
> 
> Compiles. Some apps works.
> 
> 
> Thanks,
> 
> Yue Liu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130110/13c966b9/attachment.htm>