plasma and new shadow mess

[Weng Xuetian]

On Sun, Jan 6, 2013 at 10:37 AM, Aaron J. Seigo <aseigo at kde.org> wrote:

> On Sunday, January 6, 2013 13:35:16 Martin Graesslin wrote:
>
> btw, these changes were made in mid-November of 2012. i'm a little
> surprised
> people are only noticing now.
>

I'm sure this change is not included the first beta, people might see
things goes alright and then we have Christmas which worse the case.

I'm working on some of fix.. those changes go into 4.10 or 4.11 I don't
really care.. but I don't want have visual regression for 4.10.
[1] https://git.reviewboard.kde.org/r/108222/
[2] https://git.reviewboard.kde.org/r/108223/

If code is not reverted, we may discuss the solution?

As for kwin tabbox shadow, though I'm not expert for kwin, there is two
problem
1. how to do the shadow for tabbox? use X property or some kwin custom way
because it's in kwin.
Well.. I guess later way it not easy and will duplicate the shadow drawing
code path, so I still propose to use X property for passing shadow.

2. who provide the shadow, qml or the current declarativeview?
I think qml is much more easy, since the Svg object in qml is the
Plasma::Svg. If qml tabbox want to use shadow, it can pass the property to
rootObject and let declarativeview easily get and render it.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130106/7f5aac49/attachment.htm>