<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Sun, Jan 6, 2013 at 10:37 AM, Aaron J. Seigo <span dir="ltr"><<a href="mailto:aseigo@kde.org" target="_blank">aseigo@kde.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div class="im">On Sunday, January 6, 2013 13:35:16 Martin Graesslin wrote:<br></div>
<br>
btw, these changes were made in mid-November of 2012. i'm a little surprised<br>
people are only noticing now.<br>
<span class=""></span></blockquote></div><br></div><div class="gmail_extra">I'm sure this change is not included the first beta, people might see things goes alright and then we have Christmas which worse the case.<br>
<br></div><div class="gmail_extra">I'm working on some of fix.. those changes go into 4.10 or 4.11 I don't really care.. but I don't want have visual regression for 4.10.<br>[1] <a href="https://git.reviewboard.kde.org/r/108222/">https://git.reviewboard.kde.org/r/108222/</a><br>
[2] <a href="https://git.reviewboard.kde.org/r/108223/">https://git.reviewboard.kde.org/r/108223/</a><br><br></div><div class="gmail_extra">If code is not reverted, we may discuss the solution?<br></div><div class="gmail_extra">
<br></div><div class="gmail_extra">As for kwin tabbox shadow, though I'm not expert for kwin, there is two problem<br></div><div class="gmail_extra">1. how to do the shadow for tabbox? use X property or some kwin custom way because it's in kwin.<br>
</div><div class="gmail_extra">Well.. I guess later way it not easy and will duplicate the shadow drawing code path, so I still propose to use X property for passing shadow.<br></div><div class="gmail_extra"><br>2. who provide the shadow, qml or the current declarativeview?<br>
</div><div class="gmail_extra">I think qml is much more easy, since the Svg object in qml is the Plasma::Svg. If qml tabbox want to use shadow, it can pass the property to rootObject and let declarativeview easily get and render it.<br>
</div></div>