plasma and new shadow mess

[Aaron J. Seigo]

On Sunday, January 6, 2013 20:47:55 Weng Xuetian wrote:
> On Sun, Jan 6, 2013 at 10:37 AM, Aaron J. Seigo <aseigo at kde.org> wrote:
> > On Sunday, January 6, 2013 13:35:16 Martin Graesslin wrote:
> > 
> > btw, these changes were made in mid-November of 2012. i'm a little
> > surprised
> > people are only noticing now.
> 
> I'm sure this change is not included the first beta,

assuming it didn't make the release (which happened 1 week after the changes 
were made), this implies we rely on beta testers and the developers aren't 
paying attention to their own applications. this surprises me.
 
> I'm working on some of fix.. those changes go into 4.10 or 4.11 I don't
> really care.. but I don't want have visual regression for 4.10.
> [1] https://git.reviewboard.kde.org/r/108222/
> [2] https://git.reviewboard.kde.org/r/108223/

both look good, and as you noted in the reviews they actually simplify the 
code in the process. i've processed both reviews and they should go into the 
4.10 and master branches imo.

> As for kwin tabbox shadow, though I'm not expert for kwin, there is two
> problem
> 1. how to do the shadow for tabbox? use X property or some kwin custom way
> because it's in kwin.

obviously up to the kwin devs, but the x property approach should work and 
then there's no special code path to worry about: all shadows will be handled 
the same way. it would also allow the use of code in the plasmagenericshell 
library.

> 2. who provide the shadow, qml or the current declarativeview?
> I think qml is much more easy, since the Svg object in qml is the
> Plasma::Svg. If qml tabbox want to use shadow, it can pass the property to
> rootObject and let declarativeview easily get and render it.

i don't know about this one, as i'm not familiar enough with the internals of 
kwin's tab box .. i'm sure Martin or Thomas can offer direction here though.

-- 
Aaron J. Seigo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130107/d1a3d936/attachment.sig>