Review Request 108929: khtml/kjs: Implement typed-arrays

[Andrea Iacovitti]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108929/#review27353
-----------------------------------------------------------



khtml/ecma/kjs_arraybufferview.h
<http://git.reviewboard.kde.org/r/108929/#comment20578>

    Is this include really necessary or just an accident? (Noticed because a compilation error)


- Andrea Iacovitti


On Feb. 12, 2013, 10:51 p.m., Bernd Buschinski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108929/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2013, 10:51 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> khtml/kjs: Implement typed-arrays
> 
> ArrayBuffer, Int8Array, Uint8Array, Int16Array, Uint16Array, Int32Array, Uint32Array, Float32Array, Float64Array
> 
> I tested many configuration under valgrind, to find all possible errors.
> It seems other browsers don't set a limit, so you can eat all memory with these arrays (danger), so khtml/kjs also doesn't set a limit. If you feel like we really need one, please tell.
> 
> 
> Diffs
> -----
> 
>   khtml/CMakeLists.txt 99034cc 
>   khtml/ecma/kjs_arraybuffer.h PRE-CREATION 
>   khtml/ecma/kjs_arraybuffer.cpp PRE-CREATION 
>   khtml/ecma/kjs_arraybufferview.h PRE-CREATION 
>   khtml/ecma/kjs_arraybufferview.cpp PRE-CREATION 
>   khtml/ecma/kjs_window.h 1b70be1 
>   khtml/ecma/kjs_window.cpp 927d251 
> 
> Diff: http://git.reviewboard.kde.org/r/108929/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bernd Buschinski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130213/7452e0ca/attachment.htm>