Review Request 108929: khtml/kjs: Implement typed-arrays

[Milian Wolff]

> On Feb. 13, 2013, 9:13 a.m., Andrea Iacovitti wrote:
> > khtml/ecma/kjs_arraybufferview.h, line 29
> > <http://git.reviewboard.kde.org/r/108929/diff/2/?file=113855#file113855line29>
> >
> >     Is this include really necessary or just an accident? (Noticed because a compilation error)
> 
> Bernd Buschinski wrote:
>     ha, good catch, no clue how this sneaked in

Do you use KDevelop? ;-) Second report I hear today of accidental includes sneaking in...


- Milian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108929/#review27353
-----------------------------------------------------------


On Feb. 13, 2013, 8:18 p.m., Bernd Buschinski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108929/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2013, 8:18 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> khtml/kjs: Implement typed-arrays
> 
> ArrayBuffer, Int8Array, Uint8Array, Int16Array, Uint16Array, Int32Array, Uint32Array, Float32Array, Float64Array
> 
> I tested many configuration under valgrind, to find all possible errors.
> It seems other browsers don't set a limit, so you can eat all memory with these arrays (danger), so khtml/kjs also doesn't set a limit. If you feel like we really need one, please tell.
> 
> 
> Diffs
> -----
> 
>   khtml/CMakeLists.txt 99034cc 
>   khtml/ecma/kjs_arraybuffer.h PRE-CREATION 
>   khtml/ecma/kjs_arraybuffer.cpp PRE-CREATION 
>   khtml/ecma/kjs_arraybufferview.h PRE-CREATION 
>   khtml/ecma/kjs_arraybufferview.cpp PRE-CREATION 
>   khtml/ecma/kjs_window.h 1b70be1 
>   khtml/ecma/kjs_window.cpp 927d251 
> 
> Diff: http://git.reviewboard.kde.org/r/108929/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bernd Buschinski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130214/1422c75f/attachment.htm>