Review Request 108929: khtml/kjs: Implement typed-arrays

Bernd Buschinski b.buschinski at
Tue Feb 12 22:51:10 GMT 2013

This is an automatically generated e-mail. To reply, visit:

(Updated Feb. 12, 2013, 10:51 p.m.)

Review request for kdelibs.


- unsigned long -> size_t
- long -> ssize_t
- more c++ static_cast
- correct (c) + year
- minor comment fix


khtml/kjs: Implement typed-arrays

ArrayBuffer, Int8Array, Uint8Array, Int16Array, Uint16Array, Int32Array, Uint32Array, Float32Array, Float64Array

I tested many configuration under valgrind, to find all possible errors.
It seems other browsers don't set a limit, so you can eat all memory with these arrays (danger), so khtml/kjs also doesn't set a limit. If you feel like we really need one, please tell.

Diffs (updated)

  khtml/CMakeLists.txt 99034cc 
  khtml/ecma/kjs_arraybuffer.h PRE-CREATION 
  khtml/ecma/kjs_arraybuffer.cpp PRE-CREATION 
  khtml/ecma/kjs_arraybufferview.h PRE-CREATION 
  khtml/ecma/kjs_arraybufferview.cpp PRE-CREATION 
  khtml/ecma/kjs_window.h 1b70be1 
  khtml/ecma/kjs_window.cpp 927d251 




Bernd Buschinski

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list