Review Request 114219: Do not encode QString to QByteArray and cast it back to QString. This causes problem when there are Unicode characters in ${HOME}

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114219/#review44972
-----------------------------------------------------------


This review has been submitted with commit f10131de05ae979cdc7333f5ccfecbeb27265785 by Martin Gräßlin on behalf of Yichao Yu to branch KDE/4.11.

- Commit Hook


On Nov. 30, 2013, 7:55 p.m., Yichao Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114219/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2013, 7:55 p.m.)
> 
> 
> Review request for kde-workspace, David Faure, Martin Gräßlin, and Hugo Pereira Da Costa.
> 
> 
> Bugs: 327919
>     http://bugs.kde.org/show_bug.cgi?id=327919
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> list.join already returns a QString and there is no need to encode it and cast back to QString again....
> 
> P.S. for a patch that applies to both KDE4 and KF5(master for kde-workspace, frameworks for kdelibs?) How should I submit review request? Should I add both in branch or submit two review request? (But often the patch cannot apply directly due to context or file path changes).
> 
> 
> Diffs
> -----
> 
>   kcontrol/krdb/krdb.cpp 92d84e9 
> 
> Diff: http://git.reviewboard.kde.org/r/114219/diff/
> 
> 
> Testing
> -------
> 
> Compiles.
> Fixes the problem here.
> Also fixes the problem for the reporter.
> 
> 
> Thanks,
> 
> Yichao Yu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131202/e0144a7d/attachment.htm>