Review Request 114219: Do not encode QString to QByteArray and cast it back to QString. This causes problem when there are Unicode characters in ${HOME}

Yichao Yu yyc1992 at
Mon Dec 2 07:27:56 GMT 2013

This is an automatically generated e-mail. To reply, visit:

(Updated Dec. 2, 2013, 7:27 a.m.)


This change has been marked as submitted.

Review request for kde-workspace, David Faure, Martin Gräßlin, and Hugo Pereira Da Costa.

Bugs: 327919

Repository: kde-workspace


list.join already returns a QString and there is no need to encode it and cast back to QString again....

P.S. for a patch that applies to both KDE4 and KF5(master for kde-workspace, frameworks for kdelibs?) How should I submit review request? Should I add both in branch or submit two review request? (But often the patch cannot apply directly due to context or file path changes).


  kcontrol/krdb/krdb.cpp 92d84e9 



Fixes the problem here.
Also fixes the problem for the reporter.


Yichao Yu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list