Review Request 114219: Do not encode QString to QByteArray and cast it back to QString. This causes problem when there are Unicode characters in ${HOME}

[Yichao Yu]

> On Dec. 1, 2013, 3:47 a.m., David Faure wrote:
> > Yes, clearly correct.
> > 
> > For  your question about branches: commit in the "stable" branch and merge upwards (or ask the module maintainers to merge upwards).

Thank you for the review.

I don't have a git account yet (will apply soon) so could you please push that for me? I would also be very nice if you can cherry-pick this patch as well as these two[1][2] to the corresponding framework/master branches. (All of them should apply straightforwardly with difference only in the context or file paths).

Thank you.

[1] https://git.reviewboard.kde.org/r/113939/
[2] https://git.reviewboard.kde.org/r/113985/


- Yichao


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114219/#review44926
-----------------------------------------------------------


On Nov. 30, 2013, 2:55 p.m., Yichao Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114219/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2013, 2:55 p.m.)
> 
> 
> Review request for kde-workspace, David Faure, Martin Gräßlin, and Hugo Pereira Da Costa.
> 
> 
> Bugs: 327919
>     http://bugs.kde.org/show_bug.cgi?id=327919
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> list.join already returns a QString and there is no need to encode it and cast back to QString again....
> 
> P.S. for a patch that applies to both KDE4 and KF5(master for kde-workspace, frameworks for kdelibs?) How should I submit review request? Should I add both in branch or submit two review request? (But often the patch cannot apply directly due to context or file path changes).
> 
> 
> Diffs
> -----
> 
>   kcontrol/krdb/krdb.cpp 92d84e9 
> 
> Diff: http://git.reviewboard.kde.org/r/114219/diff/
> 
> 
> Testing
> -------
> 
> Compiles.
> Fixes the problem here.
> Also fixes the problem for the reporter.
> 
> 
> Thanks,
> 
> Yichao Yu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131201/f3ba1185/attachment.htm>