Review Request 112260: Enable Dict DataEngine on KF5

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112260/#review38609
-----------------------------------------------------------

Ship it!


Two minor comments.


plasma/generic/dataengines/dict/CMakeLists.txt
<http://git.reviewboard.kde.org/r/112260/#comment28557>

    We try to avoid extra whitespace in files.
    You have a blank space after plasma_engine_dict.
    
    It seems pedantic, but if we don't follow this when the next person saves the document it will show they edited the file and it messes the changelogs.
    
    For future reference in kate open Settings->Configure->Open/Save
    and under automatic cleanups select Remove trailing spaces on modified lines.



plasma/generic/dataengines/dict/CMakeLists.txt
<http://git.reviewboard.kde.org/r/112260/#comment28558>

    Where do you use KRun?
    
    Remove this line and see if it still compiles. I think it will. 


- David Edmundson


On Aug. 26, 2013, 11:09 a.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112260/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2013, 11:09 a.m.)
> 
> 
> Review request for kde-workspace.
> 
> 
> Description
> -------
> 
> Enable dict DataEngine on KF5.
> 
> 
> Diffs
> -----
> 
>   plasma/generic/dataengines/CMakeLists.txt a20ddae 
>   plasma/generic/dataengines/dict/CMakeLists.txt 2cab7c2 
>   plasma/generic/dataengines/dict/dictengine.h 24dc265 
>   plasma/generic/dataengines/dict/dictengine.cpp 127b0e0 
> 
> Diff: http://git.reviewboard.kde.org/r/112260/diff/
> 
> 
> Testing
> -------
> 
> Compiles - check
> Installs - check
> Engine Explorer - check
> Functions - check
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130826/d3ddbd84/attachment.htm>