Review Request 112260: Enable Dict DataEngine on KF5

[Bhushan Shah]

> On Aug. 26, 2013, 11:29 a.m., David Edmundson wrote:
> > plasma/generic/dataengines/dict/CMakeLists.txt, line 11
> > <http://git.reviewboard.kde.org/r/112260/diff/2/?file=184749#file184749line11>
> >
> >     We try to avoid extra whitespace in files.
> >     You have a blank space after plasma_engine_dict.
> >     
> >     It seems pedantic, but if we don't follow this when the next person saves the document it will show they edited the file and it messes the changelogs.
> >     
> >     For future reference in kate open Settings->Configure->Open/Save
> >     and under automatic cleanups select Remove trailing spaces on modified lines.

I use vim more and kate in very rare case. I have that option already enabled in Kate but missing in vim.


- Bhushan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112260/#review38609
-----------------------------------------------------------


On Aug. 26, 2013, 12:55 p.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112260/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2013, 12:55 p.m.)
> 
> 
> Review request for kde-workspace.
> 
> 
> Description
> -------
> 
> Enable dict DataEngine on KF5.
> 
> 
> Diffs
> -----
> 
>   plasma/generic/dataengines/CMakeLists.txt a20ddae 
>   plasma/generic/dataengines/dict/CMakeLists.txt 2cab7c2 
>   plasma/generic/dataengines/dict/dictengine.h 24dc265 
>   plasma/generic/dataengines/dict/dictengine.cpp 127b0e0 
> 
> Diff: http://git.reviewboard.kde.org/r/112260/diff/
> 
> 
> Testing
> -------
> 
> Compiles - check
> Installs - check
> Engine Explorer - check
> Functions - check
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130826/43774e88/attachment.htm>