Review Request 112260: Enable Dict DataEngine on KF5

Sebastian Kügler sebas at kde.org
Mon Aug 26 12:25:56 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112260/#review38608
-----------------------------------------------------------

Ship it!


please fix the whitespace and commit.

Thanks!


plasma/generic/dataengines/dict/CMakeLists.txt
<http://git.reviewboard.kde.org/r/112260/#comment28556>

    remove whitespace here


- Sebastian Kügler


On Aug. 26, 2013, 11:09 a.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112260/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2013, 11:09 a.m.)
> 
> 
> Review request for kde-workspace.
> 
> 
> Description
> -------
> 
> Enable dict DataEngine on KF5.
> 
> 
> Diffs
> -----
> 
>   plasma/generic/dataengines/CMakeLists.txt a20ddae 
>   plasma/generic/dataengines/dict/CMakeLists.txt 2cab7c2 
>   plasma/generic/dataengines/dict/dictengine.h 24dc265 
>   plasma/generic/dataengines/dict/dictengine.cpp 127b0e0 
> 
> Diff: http://git.reviewboard.kde.org/r/112260/diff/
> 
> 
> Testing
> -------
> 
> Compiles - check
> Installs - check
> Engine Explorer - check
> Functions - check
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130826/6f8a3deb/attachment.htm>


More information about the kde-core-devel mailing list