Review Request 111992: Activity bar in QML.

[Bhushan Shah]

> On Aug. 10, 2013, 5:04 p.m., David Edmundson wrote:
> > Good start.
> > 
> > You shouldn't delete the Messages.sh file.
> > Copy from something that already uses QML, such as the battery applet.
> > 
> > There's also a change from the current behaviour. The current one only shows where state = Running, it appears yours shows everything. Is this intentional?

Yes! I am showing all activities because if someone wants to switch to activity which is not running then he/she have to do it from activity manager. That don't make sense to me..


- Bhushan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111992/#review37476
-----------------------------------------------------------


On Aug. 10, 2013, 4:39 p.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111992/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2013, 4:39 p.m.)
> 
> 
> Review request for kde-workspace and Marco Martin.
> 
> 
> Description
> -------
> 
> Activity bar applet ported in QML.
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/activitybar/CMakeLists.txt 51a2edb 
>   plasma/generic/applets/activitybar/Messages.sh e73df21 
>   plasma/generic/applets/activitybar/activitybar.h b95cb0c 
>   plasma/generic/applets/activitybar/activitybar.cpp e66bf04 
>   plasma/generic/applets/activitybar/package/contents/ui/main.qml PRE-CREATION 
>   plasma/generic/applets/activitybar/package/metadata.desktop PRE-CREATION 
>   plasma/generic/applets/activitybar/plasma-applet-activitybar.desktop b7155de 
> 
> Diff: http://git.reviewboard.kde.org/r/111992/diff/
> 
> 
> Testing
> -------
> 
> Works, Tested in plasmoidviewer and desktop
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130810/1089e6cd/attachment.htm>