<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111992/">http://git.reviewboard.kde.org/r/111992/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 10th, 2013, 5:04 p.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Good start.
You shouldn't delete the Messages.sh file.
Copy from something that already uses QML, such as the battery applet.
There's also a change from the current behaviour. The current one only shows where state = Running, it appears yours shows everything. Is this intentional?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes! I am showing all activities because if someone wants to switch to activity which is not running then he/she have to do it from activity manager. That don't make sense to me..</pre>
<br />
<p>- Bhushan</p>
<br />
<p>On August 10th, 2013, 4:39 p.m. UTC, Bhushan Shah wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kde-workspace and Marco Martin.</div>
<div>By Bhushan Shah.</div>
<p style="color: grey;"><i>Updated Aug. 10, 2013, 4:39 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Activity bar applet ported in QML.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works, Tested in plasmoidviewer and desktop</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/applets/activitybar/CMakeLists.txt <span style="color: grey">(51a2edb)</span></li>
<li>plasma/generic/applets/activitybar/Messages.sh <span style="color: grey">(e73df21)</span></li>
<li>plasma/generic/applets/activitybar/activitybar.h <span style="color: grey">(b95cb0c)</span></li>
<li>plasma/generic/applets/activitybar/activitybar.cpp <span style="color: grey">(e66bf04)</span></li>
<li>plasma/generic/applets/activitybar/package/contents/ui/main.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/activitybar/package/metadata.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/activitybar/plasma-applet-activitybar.desktop <span style="color: grey">(b7155de)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111992/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>