Moving libkfacebook to extragear

Martin Klapetek martin.klapetek at gmail.com
Mon Oct 29 09:35:59 GMT 2012


On Mon, Oct 29, 2012 at 8:28 AM, Kevin Krammer <krammer at kde.org> wrote:

>
> I think you can remove m_accessToken, m_path and m_queryItems from
> FacebookJob.
> Access token and path are already set on m_url and addQueryItem can be
> implemented to just call m_url.addQueryItem().
>
> Also, virtual void start() = 0 is already part of KJob's API, so not needed
> again.
>

Good points, all fixed.

Cheers
-- 
Martin Klapetek | KDE Developer
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20121029/c6422214/attachment.htm>


More information about the kde-core-devel mailing list