Moving libkfacebook to extragear

Kevin Krammer krammer at
Mon Oct 29 10:44:19 GMT 2012

On Monday, 2012-10-29, Martin Klapetek wrote:
> On Mon, Oct 29, 2012 at 8:28 AM, Kevin Krammer <krammer at> wrote:
> > I think you can remove m_accessToken, m_path and m_queryItems from
> > FacebookJob.
> > Access token and path are already set on m_url and addQueryItem can be
> > implemented to just call m_url.addQueryItem().
> > 
> > Also, virtual void start() = 0 is already part of KJob's API, so not
> > needed again.
> Good points, all fixed.

Almost :)
FacebookJob::m_queryItems is still there. can probably also remove the typedef 
for QueryItem.

Kevin Krammer, KDE developer, xdg-utils developer
KDE user support, developer mentoring
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <>

More information about the kde-core-devel mailing list