Review Request: Keep KService::createInstance error message in KServiceTypeTrader::createInstanceFromQuery

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107032/#review20920
-----------------------------------------------------------

Ship it!


OK.

In case of multiple offers with error, this will return the error from the loading of the last one, but I guess that's OK (no room for all, and the problem is probably the same on all of them anyway, e.g. undef symbol in Qt or another shared lib).

- David Faure


On Oct. 25, 2012, 12:12 a.m., Milian Wolff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107032/
> -----------------------------------------------------------
> 
> (Updated Oct. 25, 2012, 12:12 a.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Description
> -------
> 
> When KServiceTypeTrader::createInstanceFromQuery fails in KService::createInstance, the error message is currently overwritten by the useless information "No service matching the requirements was found". This patch fixes that to keep the error message set by KService::createInstance and thus give me something more useful like e.g. "Cannot load library /home/milian/projects/compiled/kde4/lib/kde4/kdevqmljslanguagesupport.so: (libqtc-qmlsupport.so: cannot open shared object file: No such file or directory)" ' 
> 
> 
> Diffs
> -----
> 
>   kdecore/services/kservicetypetrader.h 8641fe6 
> 
> Diff: http://git.reviewboard.kde.org/r/107032/diff/
> 
> 
> Testing
> -------
> 
> changed the header, ran KDevelop with invalid plugins, got actually useful output (see above). Another example that was overwritten as well before this patch:
> 
> "Cannot load library /home/milian/projects/compiled/kde4/lib/kde4/kdevfiletemplates.so: (/home/milian/projects/compiled/kde4/lib/kde4/kdevfiletemplates.so: undefined symbol: _ZTIN8KDevelop17ITemplateProviderE)" ' 
> 
> 
> Thanks,
> 
> Milian Wolff
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20121025/3d6c3e8b/attachment.htm>