Review Request: Keep KService::createInstance error message in KServiceTypeTrader::createInstanceFromQuery

Milian Wolff mail at
Thu Oct 25 01:12:44 BST 2012

This is an automatically generated e-mail. To reply, visit:

Review request for kdelibs and David Faure.


When KServiceTypeTrader::createInstanceFromQuery fails in KService::createInstance, the error message is currently overwritten by the useless information "No service matching the requirements was found". This patch fixes that to keep the error message set by KService::createInstance and thus give me something more useful like e.g. "Cannot load library /home/milian/projects/compiled/kde4/lib/kde4/ ( cannot open shared object file: No such file or directory)" ' 


  kdecore/services/kservicetypetrader.h 8641fe6 



changed the header, ran KDevelop with invalid plugins, got actually useful output (see above). Another example that was overwritten as well before this patch:

"Cannot load library /home/milian/projects/compiled/kde4/lib/kde4/ (/home/milian/projects/compiled/kde4/lib/kde4/ undefined symbol: _ZTIN8KDevelop17ITemplateProviderE)" ' 


Milian Wolff

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list