<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107032/">http://git.reviewboard.kde.org/r/107032/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">OK.
In case of multiple offers with error, this will return the error from the loading of the last one, but I guess that's OK (no room for all, and the problem is probably the same on all of them anyway, e.g. undef symbol in Qt or another shared lib).</pre>
<br />
<p>- David</p>
<br />
<p>On October 25th, 2012, 12:12 a.m., Milian Wolff wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs and David Faure.</div>
<div>By Milian Wolff.</div>
<p style="color: grey;"><i>Updated Oct. 25, 2012, 12:12 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When KServiceTypeTrader::createInstanceFromQuery fails in KService::createInstance, the error message is currently overwritten by the useless information "No service matching the requirements was found". This patch fixes that to keep the error message set by KService::createInstance and thus give me something more useful like e.g. "Cannot load library /home/milian/projects/compiled/kde4/lib/kde4/kdevqmljslanguagesupport.so: (libqtc-qmlsupport.so: cannot open shared object file: No such file or directory)" '
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">changed the header, ran KDevelop with invalid plugins, got actually useful output (see above). Another example that was overwritten as well before this patch:
"Cannot load library /home/milian/projects/compiled/kde4/lib/kde4/kdevfiletemplates.so: (/home/milian/projects/compiled/kde4/lib/kde4/kdevfiletemplates.so: undefined symbol: _ZTIN8KDevelop17ITemplateProviderE)" '
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdecore/services/kservicetypetrader.h <span style="color: grey">(8641fe6)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107032/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>