Review Request: Add pkgconfig hints to FindSamba.cmake

[Rex Dieter]

> On Oct. 21, 2012, 9:27 a.m., Raphael Kubo da Costa wrote:
> > cmake/modules/FindSamba.cmake, line 23
> > <http://git.reviewboard.kde.org/r/106861/diff/2/?file=90523#file90523line23>
> >
> >     Please note that support for the QUIET keyword was added in CMake 2.8.2 -- it is probably OK for the 4.10 branch once we start depending on CMake 2.8.8, but not for the other ones.

There are a *lot* of other cmake modules shipped with kdelibs currently that do the same.

$ grep -i pkg_check_modules /usr/share/kde4/apps/cmake/modules/*.cmake | grep -i quiet | wc -l
30

That said, using quiet is certainly not a requirement here and could be dropped if it's considered a blocker.


- Rex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106861/#review20611
-----------------------------------------------------------


On Oct. 15, 2012, 12:24 p.m., Rex Dieter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106861/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2012, 12:24 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> Add pkgconfig hints to FindSamba.cmake, helps find samba4 libs on non-standard-ish locations.
> 
> 
> Diffs
> -----
> 
>   cmake/modules/FindSamba.cmake 16522c6 
> 
> Diff: http://git.reviewboard.kde.org/r/106861/diff/
> 
> 
> Testing
> -------
> 
> Tested on fedora 18 against samba-4.0-rc2
> 
> 
> Thanks,
> 
> Rex Dieter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20121022/4f85f39b/attachment.htm>