Review Request: Add pkgconfig hints to FindSamba.cmake

Raphael Kubo da Costa rakuco at FreeBSD.org
Sun Oct 21 10:27:47 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106861/#review20611
-----------------------------------------------------------



cmake/modules/FindSamba.cmake
<http://git.reviewboard.kde.org/r/106861/#comment16254>

    Please note that support for the QUIET keyword was added in CMake 2.8.2 -- it is probably OK for the 4.10 branch once we start depending on CMake 2.8.8, but not for the other ones.


- Raphael Kubo da Costa


On Oct. 15, 2012, 12:24 p.m., Rex Dieter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106861/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2012, 12:24 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> Add pkgconfig hints to FindSamba.cmake, helps find samba4 libs on non-standard-ish locations.
> 
> 
> Diffs
> -----
> 
>   cmake/modules/FindSamba.cmake 16522c6 
> 
> Diff: http://git.reviewboard.kde.org/r/106861/diff/
> 
> 
> Testing
> -------
> 
> Tested on fedora 18 against samba-4.0-rc2
> 
> 
> Thanks,
> 
> Rex Dieter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20121021/6cca24f0/attachment.htm>


More information about the kde-core-devel mailing list