Review Request: Add pkgconfig hints to FindSamba.cmake
neundorf at kde.org
Tue Oct 23 21:27:10 BST 2012
On Monday 22 October 2012, Rex Dieter wrote:
> > On Oct. 21, 2012, 9:27 a.m., Raphael Kubo da Costa wrote:
> > > cmake/modules/FindSamba.cmake, line 23
> > > <http://git.reviewboard.kde.org/r/106861/diff/2/?file=90523#file90523li
> > > ne23>
> > >
> > > Please note that support for the QUIET keyword was added in CMake
> > > 2.8.2 -- it is probably OK for the 4.10 branch once we start
> > > depending on CMake 2.8.8, but not for the other ones.
> There are a *lot* of other cmake modules shipped with kdelibs currently
> that do the same.
> $ grep -i pkg_check_modules /usr/share/kde4/apps/cmake/modules/*.cmake |
> grep -i quiet | wc -l 30
> That said, using quiet is certainly not a requirement here and could be
> dropped if it's considered a blocker.
Raphael is right that the QUIET keyword was added to FindPkgConfig.cmake in
CMake with version 2.8.2, but this was done after it had been for some time in
the FindPkgConfig.cmake coming with kdelibs already.
So it is ok to use it (since FindPkgConfig.cmake in kdelibs supports it).
More information about the kde-core-devel