Review Request: Fix in documentation (comment in header): QPrinter::PaperSize instead of QPrinter::PageSize

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107356/#review22246
-----------------------------------------------------------

Ship it!


1) never trust documentation :) There is a PageSize enum, it's just deprecated (so, actually, you can find it in the documentation, it's just a bit more hidden)

2) For KF5 we can't use a proper enum type here, because QPrinter has moved to the "print support" library, which would be a dependency just for that. Same in kdelibs4, actually, it doesn't use QPrinter because that's in QtGui, and klocale is in kdecore.

3) Your patch is OK though. I just checked, and PageSize is just a typedef for PaperSize, so the actual int values are the same, so no porting problem. Phew.

- David Faure


On Nov. 17, 2012, 10:31 a.m., Thomas Fischer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107356/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2012, 10:31 a.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> According to the latest Qt documentation, there is no PageSize enum in QPrinter, only a PaperSize enum.
> 
> BTW, wouldn't it be a good idea for KDE5 (not to break anything now, but add a "//KDE5" comment) to use QPrinter's enum directly instead of an int and to rename the functions to paperSize() and setPaperSize(..), respectively?
> 
> 
> Diffs
> -----
> 
>   kdecore/localization/klocale.h cdbc3d3 
> 
> Diff: http://git.reviewboard.kde.org/r/107356/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Thomas Fischer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20121120/2e1bb809/attachment.htm>