Review Request: Fix in documentation (comment in header): QPrinter::PaperSize instead of QPrinter::PageSize

Thomas Fischer fischer at unix-ag.uni-kl.de
Sat Nov 17 10:31:31 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107356/
-----------------------------------------------------------

Review request for kdelibs.


Description
-------

According to the latest Qt documentation, there is no PageSize enum in QPrinter, only a PaperSize enum.

BTW, wouldn't it be a good idea for KDE5 (not to break anything now, but add a "//KDE5" comment) to use QPrinter's enum directly instead of an int and to rename the functions to paperSize() and setPaperSize(..), respectively?


Diffs
-----

  kdecore/localization/klocale.h cdbc3d3 

Diff: http://git.reviewboard.kde.org/r/107356/diff/


Testing
-------


Thanks,

Thomas Fischer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20121117/c1e4ae52/attachment.htm>


More information about the kde-core-devel mailing list