Review Request: favicon local cache

Jaime Torres Amate jtamate at gmail.com
Sat Nov 17 10:56:05 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107358/
-----------------------------------------------------------

Review request for kdelibs.


Description
-------

Does not fix the bugs (I'll not mark them as fixed), but makes them much harder to reproduce.
Just use a static QHash most of the time instead of a blocking Dbus call.


This addresses bugs 306338 and 307973.
    http://bugs.kde.org/show_bug.cgi?id=306338
    http://bugs.kde.org/show_bug.cgi?id=307973


Diffs
-----

  kdecore/services/kmimetype.cpp 955bf62 

Diff: http://git.reviewboard.kde.org/r/107358/diff/


Testing
-------

In my tests, there are more than 5 thousands requests for a favicon answered by the local cache vs. less than new 50 favicons inserted.


Thanks,

Jaime Torres Amate

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20121117/086c5c13/attachment.htm>


More information about the kde-core-devel mailing list