Review Request: proper fix for my inexcusable commit without review

Jaime Torres Amate jtamate at
Fri Jun 29 17:22:36 BST 2012

This is an automatically generated e-mail. To reply, visit:

(Updated June 29, 2012, 4:22 p.m.)

Review request for kdelibs.


It is not possible to fix the memory leak in void KAction::setAuthAction(const QString &actionName) the way I tried.
kdelibs will have it until frameworks is ready.
Therefore, replace the delete by just two comments.


the action created locally in void KAction::setAuthAction(const QString &actionName) is deleted.
The others must be handled by the callers of void KAction::setAuthAction(KAuth::Action *action).

Diffs (updated)

  kdeui/actions/kaction.cpp 0f6343c 



working with it this afternoon.


Jaime Torres Amate

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list