Review Request: proper fix for my inexcusable commit without review

Jaime Torres Amate jtamate at gmail.com
Tue Jun 26 20:06:39 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105364/
-----------------------------------------------------------

Review request for kdelibs.


Description
-------

the action created locally in void KAction::setAuthAction(const QString &actionName) is deleted.
The others must be handled by the callers of void KAction::setAuthAction(KAuth::Action *action).


Diffs
-----

  kdeui/actions/kaction.cpp 0f6343c 
  kdeui/actions/kaction_p.h 26f2b77 

Diff: http://git.reviewboard.kde.org/r/105364/diff/


Testing
-------

working with it this afternoon.


Thanks,

Jaime Torres Amate

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120626/6d907fec/attachment.htm>


More information about the kde-core-devel mailing list