Review Request: Added fallback for real username in kcm module to use KUser::FullName

[Raphael Kubo da Costa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104965/#review15187
-----------------------------------------------------------



kdepasswd/kcm/main.cpp
<http://git.reviewboard.kde.org/r/104965/#comment11891>

    Nit: 'realName' is better, as these are separate words.



kdepasswd/kcm/main.cpp
<http://git.reviewboard.kde.org/r/104965/#comment11892>

    Please follow kdelibs' coding style here (4-space indentation, surrounding braces even for single-line statements):
    
      if (foo) {
          bar();
      }


- Raphael Kubo da Costa


On May 16, 2012, 7:09 a.m., Aleksey Yermakov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104965/
> -----------------------------------------------------------
> 
> (Updated May 16, 2012, 7:09 a.m.)
> 
> 
> Review request for KDE Base Apps.
> 
> 
> Description
> -------
> 
> Added fallback for real username in kcm module.
> 
> Really helps in issues like this: http://bugs.rosalinux.ru/show_bug.cgi?id=179
> 
> Besides, such method seems natural, considering that change of real username in kcm module calls chfn to change real name in finger db, which will be reflected back in KUser::FullName.
> 
> 
> Diffs
> -----
> 
>   kdepasswd/kcm/main.cpp 2471444 
> 
> Diff: http://git.reviewboard.kde.org/r/104965/diff/
> 
> 
> Testing
> -------
> 
> Tested by QA crew of ROSA Desktop for ROSA Desktop 2012 LTS.
> 
> 
> Thanks,
> 
> Aleksey Yermakov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120627/d0a6e0a6/attachment.htm>