Review Request: fix exports using Q_DECL_EXPORT
Thiago Macieira
thiago at kde.org
Thu Jul 5 16:50:07 BST 2012
On quinta-feira, 5 de julho de 2012 13.40.48, Stephen Kelly wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105452/#review15424
> -----------------------------------------------------------
>
>
> I disagree. I think the best solution is to have a copy of the cmake
> generate export header stuff in frameworks and use the new macro in the
> copy. The copy can be removed when we depend on a later version of CMake.
If this is about frameworks, it should just use Q_DECL_EXPORT and
Q_DECL_IMPORT. No need to have macros in KDE anymore.
--
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
Software Architect - Intel Open Source Technology Center
PGP/GPG: 0x6EF45358; fingerprint:
E067 918B B660 DBD1 105C 966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120705/72f974fb/attachment.sig>
More information about the kde-core-devel
mailing list