Review Request: fix exports using Q_DECL_EXPORT

[Stephen Kelly]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105452/#review15424
-----------------------------------------------------------


I disagree. I think the best solution is to have a copy of the cmake generate export header stuff in frameworks and use the new macro in the copy. The copy can be removed when we depend on a later version of CMake.

- Stephen Kelly


On July 5, 2012, 1:09 p.m., Patrick Spendrin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105452/
> -----------------------------------------------------------
> 
> (Updated July 5, 2012, 1:09 p.m.)
> 
> 
> Review request for kdelibs, Stephen Kelly, David Faure, and Alexander Neundorf.
> 
> 
> Description
> -------
> 
> This fix is needed for some custom exports on windows. Given there is no KDE_EXPORT anymore, I use Q_DECL_EXPORT for now. See also the discussion on kde-frameworks-devel at kde.org.
> 
> 
> Diffs
> -----
> 
>   kdecore/localization/ktranscript.cpp 08ebf0e 
>   kdecore/util/kexportplugin.h 775ed48 
> 
> Diff: http://git.reviewboard.kde.org/r/105452/diff/
> 
> 
> Testing
> -------
> 
> windows only.
> 
> 
> Thanks,
> 
> Patrick Spendrin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120705/70f8186e/attachment.htm>