Review Request: Moving tabs causes wrong tab to be highlighted upon reload

Dawit Alemayehu adawit at kde.org
Sun Jan 22 18:18:54 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103740/
-----------------------------------------------------------

(Updated Jan. 22, 2012, 6:18 p.m.)


Review request for KDE Base Apps and David Faure.


Changes
-------

Updated fix that do not cause the regression found by Frank.


Description
-------

If you open several tabs with different URLs, move one of tabs past the last tab, and either press enter or reload, the text of the wrong tab is highlighted eventhough the current active tab is correctly reloaded. The attached patch fixes the bug of the wrong tab being marked as modified.


This addresses bug 266369.
    http://bugs.kde.org/show_bug.cgi?id=266369


Diffs (updated)
-----

  konqueror/src/konqtabs.cpp efaaf87 

Diff: http://git.reviewboard.kde.org/r/103740/diff/diff


Testing
-------

Follow the testcase steps outlined in the bug report.


Thanks,

Dawit Alemayehu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120122/7bc1b65a/attachment.htm>


More information about the kde-core-devel mailing list