Review Request: Moving tabs causes wrong tab to be highlighted upon reload

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103740/#review10065
-----------------------------------------------------------



konqueror/src/konqtabs.cpp
<http://git.reviewboard.kde.org/r/103740/#comment8283>

    Shouldn't this connect be removed then?
    
    Isn't there a risk that both signals get emitted in some cases?


- David Faure


On Jan. 22, 2012, 6:18 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103740/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2012, 6:18 p.m.)
> 
> 
> Review request for KDE Base Apps and David Faure.
> 
> 
> Description
> -------
> 
> If you open several tabs with different URLs, move one of tabs past the last tab, and either press enter or reload, the text of the wrong tab is highlighted eventhough the current active tab is correctly reloaded. The attached patch fixes the bug of the wrong tab being marked as modified.
> 
> 
> This addresses bug 266369.
>     http://bugs.kde.org/show_bug.cgi?id=266369
> 
> 
> Diffs
> -----
> 
>   konqueror/src/konqtabs.cpp efaaf87 
> 
> Diff: http://git.reviewboard.kde.org/r/103740/diff/diff
> 
> 
> Testing
> -------
> 
> Follow the testcase steps outlined in the bug report.
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120125/5b07487f/attachment.htm>