Review Request: Moving tabs causes wrong tab to be highlighted upon reload

[Dawit Alemayehu]

> On Jan. 21, 2012, 8:43 p.m., Frank Reininghaus wrote:
> > Your patch fixes the bug, but it also causes a regression: If the tab contains a split view, the tab title is not highlighted any more. It seems that the purpose of the function KonqFrameTabs::tabWhereActive() is to get the tab index right for split views.
> > 
> > Maybe a better fix would be to reorder the list m_childFrameList when a 'tabMoved(int,int)' signal is received?

Indeed. There is already a slot, slotMovedTab, that handles the update of the m_childFrameList container, but it only connects to the deprecated KTabWidget::movedTab(int,int) signal. Hence, simply connecting the same slot to the QTabBar::tabMoved(int,int) signal is the proper fix for this issue. Thanks for catching that.


- Dawit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103740/#review9993
-----------------------------------------------------------


On Jan. 19, 2012, 9:28 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103740/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2012, 9:28 p.m.)
> 
> 
> Review request for KDE Base Apps and David Faure.
> 
> 
> Description
> -------
> 
> If you open several tabs with different URLs, move one of tabs past the last tab, and either press enter or reload, the text of the wrong tab is highlighted eventhough the current active tab is correctly reloaded. The attached patch fixes the bug of the wrong tab being marked as modified.
> 
> 
> This addresses bug 266369.
>     http://bugs.kde.org/show_bug.cgi?id=266369
> 
> 
> Diffs
> -----
> 
>   konqueror/src/konqtabs.h 0e229a0 
>   konqueror/src/konqtabs.cpp efaaf87 
> 
> Diff: http://git.reviewboard.kde.org/r/103740/diff/diff
> 
> 
> Testing
> -------
> 
> Follow the testcase steps outlined in the bug report.
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120122/96dcdaa3/attachment.htm>