Review Request: Fix capacity text in places panel (and possibly unwanted spin-up behavior)
Peter Penz
peter.penz19 at gmail.com
Thu Jan 12 16:55:43 GMT 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103682/#review9772
-----------------------------------------------------------
I'm not the maintainer of the code, but the patch looks good. Definitely a "go" from a Dolphin point of view to get this in before 4.8.0 got tagged. Thanks a lot for this patch - I stumbled above those issues myself already but did not have the time yet to check KFilePlacesView...
- Peter Penz
On Jan. 12, 2012, 4:42 p.m., Christoph Feck wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103682/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2012, 4:42 p.m.)
>
>
> Review request for Dolphin, kdelibs and Solid.
>
>
> Description
> -------
>
> I only tried to fix the double/blurry text (bug 248062), but stumbled upon a possible reason for the unwanted spin-up behavior reported in the other bugs. According to the code, the KFreeDiskSpaceInfo object is queried even if we do not display the capacity bar.
>
> The attached patch should fix it:
> - the text is not faded at two positions, but moved between those two positions
> - the KFreeDiskSpaceInfo object is only created if we indeed want to show the capacity bar
>
> I tried to separate the patches for those two issues, but it was not possible.
>
> Please review.
>
>
> This addresses bugs 184449, 248062, 261552, 264487, and 268103.
> http://bugs.kde.org/show_bug.cgi?id=184449
> http://bugs.kde.org/show_bug.cgi?id=248062
> http://bugs.kde.org/show_bug.cgi?id=261552
> http://bugs.kde.org/show_bug.cgi?id=264487
> http://bugs.kde.org/show_bug.cgi?id=268103
>
>
> Diffs
> -----
>
> kfile/kfileplacesview.cpp 6a343b3
>
> Diff: http://git.reviewboard.kde.org/r/103682/diff/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Christoph Feck
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120112/0a2cae88/attachment.htm>
More information about the kde-core-devel
mailing list