Review Request: Filter user input when creating a shortcut link to a URL location

[Dawit Alemayehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103684/
-----------------------------------------------------------

Review request for kdelibs.


Description
-------

If a user enters, www.kde.org, in the URL location link file creation dialog, then the generated .desktop file entry would contain a URL entry without a scheme and as a result opening the link in Konqueror fails. Moreover, the code that attempts to determine the icon to associate with the newly created link file also fails to obtain the proper icon because of the missing scheme. The attached patch addresses both those issues by filtering the user input using the shorturifilter. Note that this problem was discovered while evaluting the afforementioned bug report.


This addresses bug 224142.
    http://bugs.kde.org/show_bug.cgi?id=224142


Diffs
-----

  kfile/knewfilemenu.cpp 07db5b8 

Diff: http://git.reviewboard.kde.org/r/103684/diff/diff


Testing
-------


Thanks,

Dawit Alemayehu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120112/161e9789/attachment.htm>