Review Request: Fix capacity text in places panel (and possibly unwanted spin-up behavior)

[Christoph Feck]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103682/
-----------------------------------------------------------

Review request for Dolphin, kdelibs and Solid.


Description
-------

I only tried to fix the double/blurry text (bug 248062), but stumbled upon a possible reason for the unwanted spin-up behavior reported in the other bugs. According to the code, the KFreeDiskSpaceInfo object is queried even if we do not display the capacity bar.

The attached patch should fix it:
- the text is not faded at two positions, but moved between those two positions
- the KFreeDiskSpaceInfo object is only created if we indeed want to show the capacity bar

I tried to separate the patches for those two issues, but it was not possible.

Please review.


This addresses bugs 184449, 248062, 261552, 264487, and 268103.
    http://bugs.kde.org/show_bug.cgi?id=184449
    http://bugs.kde.org/show_bug.cgi?id=248062
    http://bugs.kde.org/show_bug.cgi?id=261552
    http://bugs.kde.org/show_bug.cgi?id=264487
    http://bugs.kde.org/show_bug.cgi?id=268103


Diffs
-----

  kfile/kfileplacesview.cpp 6a343b3 

Diff: http://git.reviewboard.kde.org/r/103682/diff/diff


Testing
-------


Thanks,

Christoph Feck

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120112/cf4b2fca/attachment.htm>