Review Request: Prevent Konqueror crash when the location toolbar is disabled

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103663/#review9677
-----------------------------------------------------------

Ship it!


Looks good, thanks for the fix.


konqueror/src/konqmainwindow.cpp
<http://git.reviewboard.kde.org/r/103663/#comment7962>

    The comment should be adjusted to "the empty match case is handled directly", or removed (it doesn't seem useful, in fact).


- David Faure


On Jan. 9, 2012, 8:33 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103663/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2012, 8:33 p.m.)
> 
> 
> Review request for KDE Base Apps.
> 
> 
> Description
> -------
> 
> The attached patch is an attempt to prevent access of a NULL m_combo variable whenever the user removes the location toolbar. Since the location toolbar is the parent of m_combo, its deletion means the the deletion of m_combo as well.
> 
> 
> This addresses bug 172692.
>     http://bugs.kde.org/show_bug.cgi?id=172692
> 
> 
> Diffs
> -----
> 
>   konqueror/src/konqmainwindow.cpp 7675e3a 
> 
> Diff: http://git.reviewboard.kde.org/r/103663/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120109/e7eeab84/attachment.htm>