Review Request: Prevent Konqueror crash when the location toolbar is disabled

Dawit Alemayehu adawit at kde.org
Mon Jan 9 20:33:22 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103663/
-----------------------------------------------------------

Review request for KDE Base Apps.


Description
-------

The attached patch is an attempt to prevent access of a NULL m_combo variable whenever the user removes the location toolbar. Since the location toolbar is the parent of m_combo, its deletion means the the deletion of m_combo as well.


This addresses bug 172692.
    http://bugs.kde.org/show_bug.cgi?id=172692


Diffs
-----

  konqueror/src/konqmainwindow.cpp 7675e3a 

Diff: http://git.reviewboard.kde.org/r/103663/diff/diff


Testing
-------


Thanks,

Dawit Alemayehu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120109/e0c1458c/attachment.htm>


More information about the kde-core-devel mailing list