Review Request: Prevent Konqueror crash when the location toolbar is disabled

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103663/#review9680
-----------------------------------------------------------


This review has been submitted with commit b21b16103a643d0a1b4cd3c9711774d8908d240c by Dawit Alemayehu to branch KDE/4.8.

- Commit Hook


On Jan. 9, 2012, 8:33 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103663/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2012, 8:33 p.m.)
> 
> 
> Review request for KDE Base Apps.
> 
> 
> Description
> -------
> 
> The attached patch is an attempt to prevent access of a NULL m_combo variable whenever the user removes the location toolbar. Since the location toolbar is the parent of m_combo, its deletion means the the deletion of m_combo as well.
> 
> 
> This addresses bug 172692.
>     http://bugs.kde.org/show_bug.cgi?id=172692
> 
> 
> Diffs
> -----
> 
>   konqueror/src/konqmainwindow.cpp 7675e3a 
> 
> Diff: http://git.reviewboard.kde.org/r/103663/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120110/fa78e7e8/attachment.htm>