Review Request: Fix FindXine.cmake to use pkg-config instead of xine-config

Andreas Pakulat apaku at gmx.de
Thu Jan 5 13:28:35 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103631/#review9569
-----------------------------------------------------------


Like Eike said, use the PkgConfig module with pkg-config. For a good example see the FindLibXml2.cmake file.

- Andreas Pakulat


On Jan. 5, 2012, 11:25 a.m., Johannes Huber wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103631/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2012, 11:25 a.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> This is a gentoo downstream patch, see bug https://bugs.gentoo.org/show_bug.cgi?id=397595 for cause.
> 
> 
> Diffs
> -----
> 
>   cmake/modules/FindXine.cmake 37c58c6 
> 
> Diff: http://git.reviewboard.kde.org/r/103631/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Johannes Huber
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120105/f8c88f8f/attachment.htm>


More information about the kde-core-devel mailing list