Review Request: Fix FindXine.cmake to use pkg-config instead of xine-config

[Alexander Neundorf]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103631/#review9582
-----------------------------------------------------------


Please don't commit it.

As others have said, if you use pkg-config, use the FindPkgConfig.cmake module coming with cmake.

But, I just had a very quick look at xine.h:
hammer:/usr/include$ grep VERS xine.h 
#define XINE_MAJOR_VERSION 1
#define XINE_MINOR_VERSION 1
#define XINE_SUB_VERSION   19
#define XINE_VERSION       "1.1.19"

I would prefer if instead you would use file(READ ) to read xine.h into a cmake variable, and then use the string()-regexp functions to capture XINE_VERSION from that file.
This way no program has to be run at all (which helps if somebody wants to use it in cross-compiling), and also on systems which don't have pkg-config.


- Alexander Neundorf


On Jan. 5, 2012, 11:25 a.m., Johannes Huber wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103631/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2012, 11:25 a.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> This is a gentoo downstream patch, see bug https://bugs.gentoo.org/show_bug.cgi?id=397595 for cause.
> 
> 
> Diffs
> -----
> 
>   cmake/modules/FindXine.cmake 37c58c6 
> 
> Diff: http://git.reviewboard.kde.org/r/103631/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Johannes Huber
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120105/2d84e8ea/attachment.htm>