Review Request: Do not emit KEditToolBar::newToolBarConfig twice

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103579/#review9475
-----------------------------------------------------------

Ship it!


Nice solution :-)


kdeui/dialogs/kedittoolbar.cpp
<http://git.reviewboard.kde.org/r/103579/#comment7767>

    futher -> further


- David Faure


On Jan. 2, 2012, 6:25 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103579/
> -----------------------------------------------------------
> 
> (Updated Jan. 2, 2012, 6:25 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> The attached one liner patch stops KEditToolBar from emitting the newToolBarConfig signal when the user presses the OK button  without modifying anything after pressing Apply. IOW, the changes have already been applied.
> 
> 
> Diffs
> -----
> 
>   kdeui/dialogs/kedittoolbar.cpp ed572bf 
> 
> Diff: http://git.reviewboard.kde.org/r/103579/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120102/e67b056d/attachment.htm>