Review Request: Do not emit KEditToolBar::newToolBarConfig twice

Dawit Alemayehu adawit at kde.org
Mon Jan 2 18:25:49 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103579/
-----------------------------------------------------------

(Updated Jan. 2, 2012, 6:25 p.m.)


Review request for kdelibs.


Changes
-------

Emit the "newToolBarConfig" signal only if the user has not already pressed Apply button after making changes.


Description
-------

The attached one liner patch stops KEditToolBar from emitting the newToolBarConfig signal when the user presses the OK button  without modifying anything after pressing Apply. IOW, the changes have already been applied.


Diffs (updated)
-----

  kdeui/dialogs/kedittoolbar.cpp ed572bf 

Diff: http://git.reviewboard.kde.org/r/103579/diff/diff


Testing
-------


Thanks,

Dawit Alemayehu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120102/e840f5aa/attachment.htm>


More information about the kde-core-devel mailing list