Review Request: Do not emit KEditToolBar::newToolBarConfig twice

Commit Hook null at kde.org
Mon Jan 2 19:02:05 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103579/#review9476
-----------------------------------------------------------


This review has been submitted with commit 74a7bf7dbd530678bb93220df8ede30a1f773af6 by Dawit Alemayehu to branch KDE/4.8.

- Commit Hook


On Jan. 2, 2012, 6:25 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103579/
> -----------------------------------------------------------
> 
> (Updated Jan. 2, 2012, 6:25 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> The attached one liner patch stops KEditToolBar from emitting the newToolBarConfig signal when the user presses the OK button  without modifying anything after pressing Apply. IOW, the changes have already been applied.
> 
> 
> Diffs
> -----
> 
>   kdeui/dialogs/kedittoolbar.cpp ed572bf 
> 
> Diff: http://git.reviewboard.kde.org/r/103579/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120102/85a0f43d/attachment.htm>


More information about the kde-core-devel mailing list