Review Request: Do not emit KEditToolBar::newToolBarConfig twice

[Dawit Alemayehu]

> On Jan. 2, 2012, 10:28 a.m., David Faure wrote:
> > This makes _k_slotOK call reject() instead of accept(), which might create issues in the users of the dialog.
> > 
> > I think a different fix is needed, usually this is done via a bool "dirty", i.e. "there are changes to be saved", and not doing anything if there are no changes to be saved.

There is actually no need for a new flag. We can simply use the state of the "Apply" button to determine whether we should emit the signal or not. Will patch a new patch based on that.


- Dawit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103579/#review9429
-----------------------------------------------------------


On Dec. 30, 2011, 6:39 a.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103579/
> -----------------------------------------------------------
> 
> (Updated Dec. 30, 2011, 6:39 a.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> The attached one liner patch stops KEditToolBar from emitting the newToolBarConfig signal when the user presses the OK button  without modifying anything after pressing Apply. IOW, the changes have already been applied.
> 
> 
> Diffs
> -----
> 
>   kdeui/dialogs/kedittoolbar.cpp ed572bf 
> 
> Diff: http://git.reviewboard.kde.org/r/103579/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120102/369db604/attachment.htm>