Review Request: New KPart extension for manupilating a browser engine's settings

[Dawit Alemayehu]

> On Feb. 20, 2012, 10:58 a.m., David Faure wrote:
> > Looks OK. Technically all this is related to HTML, it doesn't possibly apply to other kinds of kparts, so it could be made part of the existing HtmlExtension class, by adding a new interface for the settings-related methods.
> > 
> > I would find this cleaner -- but I'm not blocking this just for naming.

Actually that is a good idea. All those settings/attributes are indeed HTML specific and I doubt there will be any common settings amongst any of the KPart components ; so it is better to move the function itself into the already existing HTMLSetting class. It also eliminates the need for adding new files. I will make this change too.


- Dawit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103973/#review10757
-----------------------------------------------------------


On Feb. 18, 2012, 9:09 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103973/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2012, 9:09 p.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Description
> -------
> 
> This patch adds a new KPart extension, BrowserSettingsExtension, for setting as well as accessing a browser engine's properties in a generic fashion from KPart plugins. This is yet another step towards making Konqueror's plugins and settings module independent of the default browser engine in use. IOW, they do not have to directly link to a specific browser engine.
> 
> 
> Diffs
> -----
> 
>   includes/CMakeLists.txt 2e7fe31 
>   includes/KParts/BrowserSettingsExtension PRE-CREATION 
>   khtml/khtml_ext.h ced53a3 
>   khtml/khtml_ext.cpp 6e8a846 
>   khtml/khtml_part.cpp 24589e4 
>   kparts/CMakeLists.txt 96fa31f 
>   kparts/browsersettingsextension.h PRE-CREATION 
>   kparts/browsersettingsextension.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/103973/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120220/96f8c6ed/attachment.htm>