<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103973/">http://git.reviewboard.kde.org/r/103973/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 20th, 2012, 10:58 a.m., <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks OK. Technically all this is related to HTML, it doesn't possibly apply to other kinds of kparts, so it could be made part of the existing HtmlExtension class, by adding a new interface for the settings-related methods.
I would find this cleaner -- but I'm not blocking this just for naming.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Actually that is a good idea. All those settings/attributes are indeed HTML specific and I doubt there will be any common settings amongst any of the KPart components ; so it is better to move the function itself into the already existing HTMLSetting class. It also eliminates the need for adding new files. I will make this change too.</pre>
<br />
<p>- Dawit</p>
<br />
<p>On February 18th, 2012, 9:09 p.m., Dawit Alemayehu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs and David Faure.</div>
<div>By Dawit Alemayehu.</div>
<p style="color: grey;"><i>Updated Feb. 18, 2012, 9:09 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds a new KPart extension, BrowserSettingsExtension, for setting as well as accessing a browser engine's properties in a generic fashion from KPart plugins. This is yet another step towards making Konqueror's plugins and settings module independent of the default browser engine in use. IOW, they do not have to directly link to a specific browser engine.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>includes/CMakeLists.txt <span style="color: grey">(2e7fe31)</span></li>
<li>includes/KParts/BrowserSettingsExtension <span style="color: grey">(PRE-CREATION)</span></li>
<li>khtml/khtml_ext.h <span style="color: grey">(ced53a3)</span></li>
<li>khtml/khtml_ext.cpp <span style="color: grey">(6e8a846)</span></li>
<li>khtml/khtml_part.cpp <span style="color: grey">(24589e4)</span></li>
<li>kparts/CMakeLists.txt <span style="color: grey">(96fa31f)</span></li>
<li>kparts/browsersettingsextension.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kparts/browsersettingsextension.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103973/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>