Review Request: New KPart extension for manupilating a browser engine's settings

[Dawit Alemayehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103973/
-----------------------------------------------------------

(Updated Feb. 20, 2012, 5:11 p.m.)


Review request for kdelibs and David Faure.


Changes
-------

Better implementation based on David's feedback. Converted BrowserSettingsExtension into a SettingsInterface of HtmlExtension instead.


Description
-------

This patch adds a new KPart extension, BrowserSettingsExtension, for setting as well as accessing a browser engine's properties in a generic fashion from KPart plugins. This is yet another step towards making Konqueror's plugins and settings module independent of the default browser engine in use. IOW, they do not have to directly link to a specific browser engine.


Diffs (updated)
-----

  khtml/khtml_ext.h ced53a3 
  khtml/khtml_ext.cpp 6e8a846 
  kparts/htmlextension.h 9833d9a 

Diff: http://git.reviewboard.kde.org/r/103973/diff/


Testing
-------


Thanks,

Dawit Alemayehu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120220/17cdd78d/attachment.htm>