Review Request: Move checks for locking primitives in KSharedDataCache to CMake

[Michael Pyne]

> On Aug. 26, 2012, 9:35 p.m., Michael Pyne wrote:
> > I've looked over everything and didn't see anything I didn't like. I'd like to apply and and compile and run what little test cases do exist, but git-apply won't run as kdecore/util/{ConfigureChecks,config-util.h}.cmake don't exist yet. Are those from stray commits on your end or is there an earlier review request that includes them?
> > 
> > I'm trying to apply to KDE/4.10 as this is not strictly a bugfix, though I didn't see either of those in KDE/4.9 or frameworks branches either.
> 
> Vadim Zhukov wrote:
>     Hm-m-m, I've checked out trunk of kdelibs... See the log of my repo:
>     
>     
>     commit 2975583acb23334efc2f13860d0f9c36462c4524
>     Author: Vadim Zhukov <persgray at gmail.com>
>     Date:   Mon Aug 27 12:01:31 2012 +0400
>     
>         Improve error printing, and mention another (related) reason to avoid semaphores.
>     
>     commit 487edb5e59b16edb63c70d3100dc1c9cc608eea8
>     Author: Vadim Zhukov <persgray at gmail.com>
>     Date:   Sun Aug 26 22:30:12 2012 +0400
>     
>         - Remove "support" for thread-shared-only locks: they do not help at all but makes app crash instead of slowly work; lack of decent locks to be resolved later.
>         - Add error checking with console printouts.
>         - Consistently use "::" before global functions.
>     
>     commit 04adbc24f5bc14828fcd8da84a322993df4a8f35
>     Author: Vadim Zhukov <persgray at gmail.com>
>     Date:   Sun Aug 26 21:17:12 2012 +0400
>     
>         Move checks for functionality (especially locking mechanisms) to CMake.
>     
>     commit 8af088493827cb1eaf6bb4aa4df89f2147986a1a
>     Merge: 58fd025 fed5ee7
>     Author: David Faure <faure at kde.org>
>     Date:   Thu Aug 16 11:04:58 2012 +0200
>     
>         Merge branch 'KDE/4.10'
>     
>     commit 0e8325376aefb912ab318c2795f276fc23a9837c
>     Author: Sergio Martins <iamsergio at gmail.com>
>     Date:   Tue Aug 14 23:16:51 2012 +0100
>     
>         s/"newer then"/"newer than"
>         (cherry picked from commit fef8d2c8ce38c735cbf2fa196006ead991a17171)
>     
>     commit 75328c0cc379d80f179ce77fc66d19706290a674
>     Merge: 557c126 c67bfaf
>     Author: David Faure <faure at kde.org>
>     Date:   Fri Jul 20 13:23:52 2012 +0200
>     
>         Merge branch 'KDE/4.9'
>     
>     commit d178c64d53fcc6ab50d35c4f178b21322b7fa357
>     Author: Michael Pyne <mpyne at kde.org>
>     Date:   Sat Jun 16 23:32:09 2012 -0400
>     
>         kshareddatacache: Correct the findEmptyPages loop boundary.
>         
>         I did review the last patch to remove 'pagesNeeded' from the loop test,
>         but I missed that it has '+ 1' instead of '- 1' (which is still too
>         conservative). The correct thing is to not have any addition at all
>         since we use operator<() for the test.
>         
>         Graciously pointed out by kde_pepo, thanks!

The current development branches on kdelibs are
* frameworks - for the upcoming KDE Platform 5. This is where most new features would be going.
* KDE/4.10 - support the upcoming KDE 4.10 release. Strictly speaking no new features can be added here but I'm willing to make the CMake changes necessary starting from this branch since we will have time to fix any issues that might arise in compilation.
* KDE/4.9 - support for the current stable branch. I would imagine the spinlock support could be backported here, if only to make OpenBSD work.

master used to be a valid branch (and may be again after KDE 5) but for now it shouldn't be used. Was there a separate patch of yours that created the CMake files in kdecore/util? I'll go double check...


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106174/#review18055
-----------------------------------------------------------


On Aug. 27, 2012, 6:54 p.m., Vadim Zhukov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106174/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2012, 6:54 p.m.)
> 
> 
> Review request for kdelibs and Michael Pyne.
> 
> 
> Description
> -------
> 
> This patch does move some run-time checks (mainly for different locking mechanisms) in KSharedDataCache to build time (CMake).
> 
> 
> This addresses bug 305023.
>     http://bugs.kde.org/show_bug.cgi?id=305023
> 
> 
> Diffs
> -----
> 
>   kdecore/util/ConfigureChecks.cmake fe9f47e 
>   kdecore/util/config-util.h.cmake 83ccdf7 
>   kdecore/util/kshareddatacache.cpp 393902e 
>   kdecore/util/kshareddatacache_p.h ec5a7a0 
> 
> Diff: http://git.reviewboard.kde.org/r/106174/diff/
> 
> 
> Testing
> -------
> 
> On OpenBSD-CURRENT.
> 
> 
> Thanks,
> 
> Vadim Zhukov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120828/a1990775/attachment.htm>